Skip to content

boards: quail: MikroBUS #89364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

boards: quail: MikroBUS #89364

merged 1 commit into from
May 21, 2025

Conversation

Ole2mail
Copy link
Contributor

@Ole2mail Ole2mail commented May 1, 2025

this introduces the four mikroBUS™ sockets hub
https://www.mikroe.com/quail

Copy link

github-actions bot commented May 1, 2025

Hello @Ole2mail, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@carlescufi
Copy link
Member

carlescufi commented May 1, 2025

@Ole2mail thanks for your contribution. Note that anonymous contributions are not allowed, you need to sign off your commits with your real name. Thanks!

@carlescufi
Copy link
Member

@Ole2mail thanks for signing the commit. You still have some CI issues though, please take a look.

@Ole2mail
Copy link
Contributor Author

Ole2mail commented May 1, 2025

@Ole2mail thanks for signing the commit. You still have some CI issues though, please take a look.

looking into this now

@Ole2mail Ole2mail force-pushed the main branch 3 times, most recently from 6995141 to 13a5c04 Compare May 2, 2025 09:58
@Ole2mail
Copy link
Contributor Author

Ole2mail commented May 5, 2025

@Ole2mail thanks for signing the commit. You still have some CI issues though, please take a look.

seems like CI is not starting automatically, which makes uncertain what else is missing to fix for the CR/MR/PR.

@Ole2mail
Copy link
Contributor Author

Ole2mail commented May 5, 2025

don't see any fixable error on CI test. seems like the one has been "cancelled". what next to do?

@Ole2mail Ole2mail force-pushed the main branch 2 times, most recently from 6dfe3c4 to f0b27a6 Compare May 6, 2025 12:43
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments related to the documentation page - thank you!

kartben
kartben previously approved these changes May 6, 2025
@Ole2mail Ole2mail force-pushed the main branch 2 times, most recently from 69f532d to df3b842 Compare May 7, 2025 17:00
@Ole2mail
Copy link
Contributor Author

if something has left unresolved yet?

@kartben kartben requested review from erwango and nordicjm May 14, 2025 07:53
kartben
kartben previously approved these changes May 14, 2025
nordicjm
nordicjm previously approved these changes May 14, 2025
kartben
kartben previously approved these changes May 14, 2025
@kartben
Copy link
Collaborator

kartben commented May 15, 2025

btw @Ole2mail please don't mark conversation as resolved and let reviewers come back to their suggestions without losing track of changes they have asked for :) https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#workflow-suggestions-that-help-reviewers
Thanks!

@Ole2mail
Copy link
Contributor Author

Ole2mail commented May 15, 2025

seems like twister run has failed because of
#89826

can be fixed temporarily by adding to the file
tests/drivers/flash/common/testcase.yaml
following lines:

   drivers.flash.common.disable_spi_nor:                                                              
     platform_exclude:                                                                                
       - mikroe_quail   

would you like me to push a separate CR/MR/PR disabling faulty test?

@kartben
Copy link
Collaborator

kartben commented May 16, 2025

@Ole2mail adding this file to the test should do the trick

diff --git a/tests/drivers/flash/common/boards/mikroe_quail.overlay b/tests/drivers/flash/common/boards/mikroe_quail.overlay
new file mode 100644
index 00000000000..88e8957e5d5
--- /dev/null
+++ b/tests/drivers/flash/common/boards/mikroe_quail.overlay
@@ -0,0 +1,18 @@
+/*
+ * Copyright (c) 2025 STMicroelectronics
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+&flash0 {
+	partitions {
+		compatible = "fixed-partitions";
+		#address-cells = <1>;
+		#size-cells = <1>;
+
+		/* Set last blocks of the code flash as storage partition */
+		storage_partition: partition@1e0000 {
+			label = "storage";
+			reg = <0x1e000 DT_SIZE_K(8)>;
+		};
+	};
+};

kartben
kartben previously approved these changes May 16, 2025
@kartben kartben requested a review from nordicjm May 16, 2025 14:12
nzmichaelh
nzmichaelh previously approved these changes May 17, 2025
The Quail board contains the following connections:

- Four MikroBUS connectors
- lined with 32 screw terminals and USB ports for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to

"""

  • 32 screw terminals
  • two USB ports, one for programming and one for external storage
    """

@Ole2mail
Copy link
Contributor Author

if something has left unresolved yet?

boards: mikroe: Add quail board

Signed-off-by: Oleg Kokorin <[email protected]>
Copy link

@kartben kartben merged commit 7b7b0de into zephyrproject-rtos:main May 21, 2025
21 checks passed
Copy link

Hi @Ole2mail!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants